Ava Chow 3c88eac28e Merge bitcoin/bitcoin#29736: test: Extends wait_for_getheaders so a specific block hash can be checked ... c4f857cc30 test: Extends wait_for_getheaders so a specific block hash can be checked (Sergi Delgado Segura) Pull request description: Fixes https://github.com/bitcoin/bitcoin/issues/18614 Previously, `wait_for_getheaders` would check whether a node had received **any** getheaders message. This implied that, if a test needed to check for a specific block hash within a headers message, it had to make sure that it was checking the desired message. This normally involved having to manually clear `last_message`. This method, apart from being too verbose, was error-prone, given an undesired `getheaders` would make tests pass. This adds the ability to check for a specific block_hash within the last `getheaders` message. ACKs for top commit: achow101: ACK c4f857cc30 BrandonOdiwuor: crACK c4f857cc30 cbergqvist: ACK c4f857cc30 stratospher: tested ACK c4f857c. went through all getheaders messages sent in the tests and checked that it's the one we want. Tree-SHA512: afc9a31673344dfaaefcf692ec2ab65958c3d4c005f5f3af525e9960f0622d8246d5311e59aba06cfd5c9e0ef9eb90a7fc8e210f030bfbe67b897c061efdeed1		2024-04-25 13:26:21 -04:00
..
crypto	test: speedup bip324_cipher.py unit test	2024-02-06 01:35:03 +01:00
__init__.py	…
address.py	…
authproxy.py	…
bdb.py	…
bip340_test_vectors.csv	…
blockfilter.py	…
blocktools.py	…
coverage.py	…
descriptors.py	…
key.py	…
messages.py	test: p2p: check disconnect due to lack of desirable service flags	2024-03-11 15:23:09 +01:00
netutil.py	test: cover UNIX sockets in feature_proxy.py	2024-03-01 14:47:29 -05:00
p2p.py	test: Extends wait_for_getheaders so a specific block hash can be checked	2024-04-04 13:36:45 +02:00
psbt.py	…
script.py	test: Fix SegwitV0SignatureMsg nLockTime signedness	2024-02-07 12:07:44 +01:00
script_util.py	…
segwit_addr.py	…
socks5.py	…
test_framework.py	Merge bitcoin/bitcoin#29498: test: Update --tmpdir doc string to say directory must not exist	2024-04-09 09:43:28 +02:00
test_node.py	Merge bitcoin/bitcoin#29279: test: p2p: check disconnect due to lack of desirable service flags	2024-03-19 17:22:04 +00:00
test_shell.py	…
util.py	fixup: get all utxos up front in fill_mempool, discourage wallet mixing	2024-04-15 18:22:32 +02:00
v2_p2p.py	[test] make v2transport arg in addconnection mandatory and few cleanups	2024-01-31 22:37:54 +05:30
wallet.py	test framework: Add and use option for tx-version in MiniWallet methods	2024-02-08 21:50:55 +00:00
wallet_util.py	Fix typos in description.md and wallet_util.py	2024-04-25 16:14:10 +08:00