glozow 5291933fed Merge bitcoin/bitcoin#25768: wallet: Properly rebroadcast unconfirmed transaction chains ... 3405f3eed5 test: Test that an unconfirmed not-in-mempool chain is rebroadcast (Andrew Chow) 10d91c5abe wallet: Deduplicate Resend and ReacceptWalletTransactions (Andrew Chow) Pull request description: Currently `ResendWalletTransactions` (used for normal rebroadcasts) will attempt to rebroadcast all of the transactions in the wallet in the order they are stored in `mapWallet`. This ends up being random as `mapWallet` is a `std::unordered_map`. However `ReacceptWalletTransactions` (used for adding to the mempool on loading) first sorts the txs by wallet insertion order, then submits them. The result is that `ResendWalletTranactions` will fail to rebroadcast child transactions if their txids happen to be lexicographically less than their parent's txid. This PR resolves this issue by combining `ReacceptWalletTransactions` and `ResendWalletTransactions` into a new `ResubmitWalletTransactions` so that the iteration code and basic checks are shared. A test has also been added that checks that such transaction chains are rebroadcast correctly. ACKs for top commit: naumenkogs: utACK 3405f3eed5 1440000bytes: reACK 3405f3eed5 furszy: Late code review ACK 3405f3ee stickies-v: ACK 3405f3eed5 Tree-SHA512: 1240d9690ecc2ae8d476286b79e2386f537a90c41dd2b8b8a5a9c2a917aa3af85d6aee019fbbb05e772985a2b197e2788305586d9d5dac78ccba1ee5aa31d77a		2022-09-05 13:54:36 +01:00
..
__init__.py	…
address.py	…
authproxy.py	…
bdb.py	…
bip340_test_vectors.csv	…
blocktools.py	remove unused functions	2022-06-24 18:04:48 +05:30
coverage.py	…
descriptors.py	…
key.py	test: Test signing psbts without explicitly having scripts	2022-06-27 16:48:04 -04:00
messages.py	test: Test that an unconfirmed not-in-mempool chain is rebroadcast	2022-08-29 12:41:50 -04:00
muhash.py	…
netutil.py	…
p2p.py	…
psbt.py	test: support passing PSBTMaps directly to PSBT ctor	2022-07-23 08:48:08 +02:00
ripemd160.py	…
script.py	…
script_util.py	…
segwit_addr.py	…
siphash.py	…
socks5.py	…
test_framework.py	test: Fail if connect_nodes fails	2022-06-22 09:15:33 +02:00
test_node.py	Create BCLog::Level::Trace log severity level	2022-08-20 11:55:17 +02:00
test_shell.py	…
util.py	test: add support for Decimal to assert_approx	2022-08-02 10:11:12 +09:00
wallet.py	test: Target exact weight in MiniWallet _bulk_tx	2022-08-03 12:02:20 +02:00
wallet_util.py	…