ddc7872c08
The extra `bilingual_str` argument of the fatal error notifications and `node::AbortNode()` is often unused and when used usually contains the same string as the message argument. It also seems to be confusing, since it is not consistently used for errors requiring user action. For example some assumeutxo fatal errors require the user to do something, but are not translated. So simplify the fatal error and abort node interfaces by only passing a translated string. This slightly changes the fatal errors displayed to the user. Also de-duplicate the abort error log since it is repeated in noui.cpp. |
||
|---|---|---|
| .. | ||
| README.md | ||
| abort.cpp | ||
| abort.h | ||
| blockmanager_args.cpp | ||
| blockmanager_args.h | ||
| blockstorage.cpp | ||
| blockstorage.h | ||
| caches.cpp | ||
| caches.h | ||
| chainstate.cpp | ||
| chainstate.h | ||
| chainstatemanager_args.cpp | ||
| chainstatemanager_args.h | ||
| coin.cpp | ||
| coin.h | ||
| coins_view_args.cpp | ||
| coins_view_args.h | ||
| connection_types.cpp | ||
| connection_types.h | ||
| context.cpp | ||
| context.h | ||
| database_args.cpp | ||
| database_args.h | ||
| eviction.cpp | ||
| eviction.h | ||
| interface_ui.cpp | ||
| interface_ui.h | ||
| interfaces.cpp | ||
| kernel_notifications.cpp | ||
| kernel_notifications.h | ||
| mempool_args.cpp | ||
| mempool_args.h | ||
| mempool_persist_args.cpp | ||
| mempool_persist_args.h | ||
| miner.cpp | ||
| miner.h | ||
| mini_miner.cpp | ||
| mini_miner.h | ||
| minisketchwrapper.cpp | ||
| minisketchwrapper.h | ||
| peerman_args.cpp | ||
| peerman_args.h | ||
| protocol_version.h | ||
| psbt.cpp | ||
| psbt.h | ||
| transaction.cpp | ||
| transaction.h | ||
| txreconciliation.cpp | ||
| txreconciliation.h | ||
| utxo_snapshot.cpp | ||
| utxo_snapshot.h | ||
| validation_cache_args.cpp | ||
| validation_cache_args.h | ||
README.md
src/node/
The src/node/ directory contains code that needs to access node state
(state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar
classes).
Code in src/node/ is meant to be segregated from code in
src/wallet/ and src/qt/, to ensure wallet and GUI
code changes don't interfere with node operation, to allow wallet and GUI code
to run in separate processes, and to perhaps eventually allow wallet and GUI
code to be maintained in separate source repositories.
As a rule of thumb, code in one of the src/node/,
src/wallet/, or src/qt/ directories should avoid
calling code in the other directories directly, and only invoke it indirectly
through the more limited src/interfaces/ classes.
This directory is at the moment
sparsely populated. Eventually more substantial files like
src/validation.cpp and
src/txmempool.cpp might be moved there.