bitcoin/src/qt
Hennadii Stepanov b7f6a89a3e
Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt`
7b7cd11244 clang-tidy, qt: Force checks for headers in `src/qt` (Hennadii Stepanov)
69eacf2c5e clang-tidy, qt: Fix `modernize-use-default-member-init` in headers (Hennadii Stepanov)

Pull request description:

  This PR split from bitcoin/bitcoin#26705 and contains only changes in `src/qt`.

  Effectively, it fixes the clang-tidy's `modernize-use-default-member-init` errors, and forces clang-tidy checks for all headers in the `src/qt` directory.

ACKs for top commit:
  jarolrod:
    ACK 7b7cd11244

Tree-SHA512: 79525bb0f31ae7cad88c781e55091a21467c0485ddc1ed03ad62e051480fda3b3710619ea11af480437edba3c6e038f7c40edc6b373e3a37408c006d11b34686
2023-01-17 09:54:56 +00:00
..
android
forms Fix Transaction Relay tooltip text in Peers details window 2022-11-16 20:54:54 -08:00
locale qt: Update translation source file for string freeze (round 2) 2022-09-14 15:03:07 +01:00
res
test scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
Makefile
README.md
addressbookpage.cpp Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
addressbookpage.h clang-tidy, qt: Fix `modernize-use-default-member-init` in headers 2022-12-16 11:58:38 +00:00
addresstablemodel.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
addresstablemodel.h
askpassphrasedialog.cpp clang-tidy, qt: Fix `modernize-use-default-member-init` in headers 2022-12-16 11:58:38 +00:00
askpassphrasedialog.h clang-tidy, qt: Fix `modernize-use-default-member-init` in headers 2022-12-16 11:58:38 +00:00
bantablemodel.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
bantablemodel.h
bitcoin.cpp Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
bitcoin.h Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
bitcoin.qrc
bitcoin_locale.qrc
bitcoinaddressvalidator.cpp
bitcoinaddressvalidator.h
bitcoinamountfield.cpp Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
bitcoinamountfield.h clang-tidy, qt: Fix `modernize-use-default-member-init` in headers 2022-12-16 11:58:38 +00:00
bitcoingui.cpp Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
bitcoingui.h Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
bitcoinstrings.cpp qt: Update translation source file for string freeze (round 2) 2022-09-14 15:03:07 +01:00
bitcoinunits.cpp
bitcoinunits.h
clientmodel.cpp Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
clientmodel.h Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
coincontroldialog.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
coincontroldialog.h
coincontroltreewidget.cpp
coincontroltreewidget.h
createwalletdialog.cpp
createwalletdialog.h
csvmodelwriter.cpp clang-tidy, qt: Fix `modernize-use-default-member-init` in headers 2022-12-16 11:58:38 +00:00
csvmodelwriter.h clang-tidy, qt: Fix `modernize-use-default-member-init` in headers 2022-12-16 11:58:38 +00:00
editaddressdialog.cpp clang-tidy, qt: Fix `modernize-use-default-member-init` in headers 2022-12-16 11:58:38 +00:00
editaddressdialog.h clang-tidy, qt: Fix `modernize-use-default-member-init` in headers 2022-12-16 11:58:38 +00:00
guiconstants.h scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
guiutil.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
guiutil.h scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
initexecutor.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
initexecutor.h
intro.cpp Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
intro.h clang-tidy, qt: Fix `modernize-use-default-member-init` in headers 2022-12-16 11:58:38 +00:00
macdockiconhandler.h
macdockiconhandler.mm
macnotificationhandler.h
macnotificationhandler.mm
macos_appnap.h
macos_appnap.mm
main.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
modaloverlay.cpp Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
modaloverlay.h Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
networkstyle.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
networkstyle.h
notificator.cpp Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
notificator.h Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
openuridialog.cpp
openuridialog.h
optionsdialog.cpp Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
optionsdialog.h Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
optionsmodel.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
optionsmodel.h scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
overviewpage.cpp Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
overviewpage.h Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
paymentserver.cpp Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
paymentserver.h clang-tidy, qt: Fix `modernize-use-default-member-init` in headers 2022-12-16 11:58:38 +00:00
peertablemodel.cpp Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
peertablemodel.h Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
peertablesortproxy.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
peertablesortproxy.h
platformstyle.cpp clang-tidy: Add `performance-no-automatic-move` check 2022-12-27 15:25:51 +00:00
platformstyle.h
psbtoperationsdialog.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
psbtoperationsdialog.h
qrimagewidget.cpp clang-tidy, qt: Fix `modernize-use-default-member-init` in headers 2022-12-16 11:58:38 +00:00
qrimagewidget.h clang-tidy, qt: Fix `modernize-use-default-member-init` in headers 2022-12-16 11:58:38 +00:00
qvalidatedlineedit.cpp Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
qvalidatedlineedit.h Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
qvaluecombobox.cpp clang-tidy, qt: Fix `modernize-use-default-member-init` in headers 2022-12-16 11:58:38 +00:00
qvaluecombobox.h clang-tidy, qt: Fix `modernize-use-default-member-init` in headers 2022-12-16 11:58:38 +00:00
receivecoinsdialog.cpp Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
receivecoinsdialog.h clang-tidy, qt: Fix `modernize-use-default-member-init` in headers 2022-12-16 11:58:38 +00:00
receiverequestdialog.cpp clang-tidy, qt: Fix `modernize-use-default-member-init` in headers 2022-12-16 11:58:38 +00:00
receiverequestdialog.h clang-tidy, qt: Fix `modernize-use-default-member-init` in headers 2022-12-16 11:58:38 +00:00
recentrequeststablemodel.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
recentrequeststablemodel.h clang-tidy, qt: Fix `modernize-use-default-member-init` in headers 2022-12-16 11:58:38 +00:00
rpcconsole.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
rpcconsole.h scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
sendcoinsdialog.cpp Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
sendcoinsdialog.h Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
sendcoinsentry.cpp Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
sendcoinsentry.h Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
sendcoinsrecipient.h
signverifymessagedialog.cpp Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
signverifymessagedialog.h clang-tidy, qt: Fix `modernize-use-default-member-init` in headers 2022-12-16 11:58:38 +00:00
splashscreen.cpp Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
splashscreen.h Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
trafficgraphwidget.cpp Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
trafficgraphwidget.h Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
transactiondesc.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
transactiondesc.h scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
transactiondescdialog.cpp
transactiondescdialog.h
transactionfilterproxy.cpp clang-tidy, qt: Fix `modernize-use-default-member-init` in headers 2022-12-16 11:58:38 +00:00
transactionfilterproxy.h clang-tidy, qt: Fix `modernize-use-default-member-init` in headers 2022-12-16 11:58:38 +00:00
transactionoverviewwidget.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
transactionoverviewwidget.h scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
transactionrecord.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
transactionrecord.h scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
transactiontablemodel.cpp Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
transactiontablemodel.h clang-tidy, qt: Fix `modernize-use-default-member-init` in headers 2022-12-16 11:58:38 +00:00
transactionview.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
transactionview.h
utilitydialog.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
utilitydialog.h
walletcontroller.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
walletcontroller.h
walletframe.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
walletframe.h
walletmodel.cpp Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
walletmodel.h Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
walletmodeltransaction.cpp Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
walletmodeltransaction.h clang-tidy, qt: Fix `modernize-use-default-member-init` in headers 2022-12-16 11:58:38 +00:00
walletview.cpp Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` 2023-01-17 09:54:56 +00:00
walletview.h clang-tidy, qt: Fix `modernize-use-default-member-init` in headers 2022-12-16 11:58:38 +00:00
winshutdownmonitor.cpp
winshutdownmonitor.h

README.md

This directory contains the source code for the Bitcoin Core graphical user interface (GUI). It uses the Qt cross-platform framework.

The current precise version for Qt 5 is specified in qt.mk.

Compile and run

See build instructions: Unix, macOS, Windows, FreeBSD, NetBSD, OpenBSD

When following your systems build instructions, make sure to install the Qt dependencies.

To run:

./src/qt/bitcoin-qt

Files and Directories

forms/

  • A directory that contains Designer UI files. These files specify the characteristics of form elements in XML. Qt UI files can be edited with Qt Creator or using any text editor.

locale/

  • Contains translations. They are periodically updated and an effort is made to support as many languages as possible. The process of contributing translations is described in doc/translation_process.md.

res/

  • Contains graphical resources used to enhance the UI experience.

test/

  • Functional tests used to ensure proper functionality of the GUI. Significant changes to the GUI code normally require new or updated tests.

bitcoingui.(h/cpp)

  • Represents the main window of the Bitcoin UI.

*model.(h/cpp)

  • The model. When it has a corresponding controller, it generally inherits from QAbstractTableModel. Models that are used by controllers as helpers inherit from other Qt classes like QValidator.
  • ClientModel is used by the main application bitcoingui and several models like peertablemodel.

*page.(h/cpp)

  • A controller. :NAMEpage.cpp generally includes :NAMEmodel.h and forms/:NAME.page.ui with a similar :NAME.

*dialog.(h/cpp)

  • Various dialogs, e.g. to open a URL. Inherit from QDialog.

paymentserver.(h/cpp)

  • (Deprecated) Used to process BIP21 payment URI requests. Also handles URI-based application switching (e.g. when following a bitcoin:... link from a browser).

walletview.(h/cpp)

  • Represents the view to a single wallet.

Other .h/cpp files

  • UI elements like BitcoinAmountField, which inherit from QWidget.
  • bitcoinstrings.cpp: automatically generated
  • bitcoinunits.(h/cpp): BTC / mBTC / etc. handling
  • callback.h
  • guiconstants.h: UI colors, app name, etc.
  • guiutil.h: several helper functions
  • macdockiconhandler.(h/mm): macOS dock icon handler
  • macnotificationhandler.(h/mm): display notifications in macOS

Contribute

See CONTRIBUTING.md for general guidelines.

Note: Do not change local/bitcoin_en.ts. It is updated automatically.

Using Qt Creator as an IDE

Qt Creator is a powerful tool which packages a UI designer tool (Qt Designer) and a C++ IDE into one application. This is especially useful if you want to change the UI layout.

Download Qt Creator

On Unix and macOS, Qt Creator can be installed through your package manager. Alternatively, you can download a binary from the Qt Website.

Note: If installing from a binary grabbed from the Qt Website: During the installation process, uncheck everything except for Qt Creator.

macOS
brew install qt-creator
Ubuntu & Debian
sudo apt-get install qtcreator

Setup Qt Creator

  1. Make sure you've installed all dependencies specified in your systems build instructions
  2. Follow the compile instructions for your system, run ./configure with the --enable-debug flag
  3. Start Qt Creator. At the start page, do: New -> Import Project -> Import Existing Project
  4. Enter bitcoin-qt as the Project Name and enter the absolute path to src/qt as Location
  5. Check over the file selection, you may need to select the forms directory (necessary if you intend to edit *.ui files)
  6. Confirm the Summary page
  7. In the Projects tab, select Manage Kits...

macOS

  • Under Kits: select the default "Desktop" kit
  • Under Compilers: select "Clang (x86 64bit in /usr/bin)"
  • Under Debuggers: select "LLDB" as debugger (you might need to set the path to your LLDB installation)

Ubuntu & Debian

Note: Some of these options may already be set

  • Under Kits: select the default "Desktop" kit
  • Under Compilers: select "GCC (x86 64bit in /usr/bin)"
  • Under Debuggers: select "GDB" as debugger
  1. While in the Projects tab, ensure that you have the bitcoin-qt executable specified under Run
  • If the executable is not specified: click "Choose...", navigate to src/qt, and select bitcoin-qt
  1. You're all set! Start developing, building, and debugging the Bitcoin Core GUI