MarcoFalke fba574c908 Merge #17349: Remove redundant copy constructors ... fa8919889f bench: Remove redundant copy constructor in mempool_stress (MarcoFalke) 29f8434368 refactor: Remove redundant PSBT copy constructor (Hennadii Stepanov) Pull request description: I fail to see why people add these copy constructors manually without explanation, when the compiler can generate them at least as good automatically with less code. ACKs for top commit: promag: ACK fa8919889f. hebasto: ACK fa8919889f, nit s/constructor/operator/ in commit fa8919889f message, as @promag [mentioned](https://github.com/bitcoin/bitcoin/pull/17349#discussion_r341776389) above. jonatack: ACK fa8919889f Tree-SHA512: ce024fdb894328f41037420b881169b8b1b48c87fbae5f432edf371a35c82e77e21468ef97cda6f54d34f1cf9bb010235d62904bb0669793457ed1c3b2a89723		2019-11-04 08:32:22 -05:00
..
bench	Merge #17349: Remove redundant copy constructors	2019-11-04 08:32:22 -05:00
compat	compat: remove bswap_* check on macOS	2019-10-24 16:01:44 -04:00
config	…
consensus	[validation] Remove fMissingInputs from AcceptToMemoryPool()	2019-10-29 15:46:45 -04:00
crypto	Fix occurences of c_str() used with size() to data()	2019-10-28 13:41:45 +01:00
index	Remove unused includes	2019-10-15 22:56:43 +00:00
interfaces	Merge #17297: refactor: Remove addrdb.h dependency from node.h	2019-11-04 13:18:27 +01:00
leveldb	…
node	doc: Fix some misspellings	2019-11-04 04:22:53 -05:00
policy	refactor: Remove redundant c_str() calls in formatting	2019-10-28 13:31:33 +01:00
primitives	Remove unused includes	2019-10-15 22:56:43 +00:00
qt	Merge #17351: doc: Fix some misspellings	2019-11-04 08:03:48 -05:00
rpc	Merge #17351: doc: Fix some misspellings	2019-11-04 08:03:48 -05:00
script	doc: Fix some misspellings	2019-11-04 04:22:53 -05:00
secp256k1	…
support	…
test	Merge #17228: test: Add RegTestingSetup to setup_common	2019-11-04 08:16:54 -05:00
univalue	Update univalue subtree	2019-10-30 16:24:02 -04:00
util	Merge #17285: doc: Bip70 removal follow-up	2019-11-02 14:47:41 +01:00
wallet	Merge #17300: LegacyScriptPubKeyMan code cleanups	2019-10-31 14:40:39 -04:00
zmq	Remove unused includes	2019-10-15 22:56:43 +00:00
.clang-format	…
Makefile.am	Merge #17297: refactor: Remove addrdb.h dependency from node.h	2019-11-04 13:18:27 +01:00
Makefile.bench.include	Merge #17292: Add new mempool benchmarks for a complex pool	2019-11-01 18:08:41 -04:00
Makefile.leveldb.include	…
Makefile.qt.include	Remove BIP70 Support	2019-10-24 16:01:43 -04:00
Makefile.qt_locale.include	…
Makefile.qttest.include	Remove BIP70 Support	2019-10-24 16:01:43 -04:00
Makefile.test.include	test: move-only ComputeFilter to src/test/lib/blockfilter	2019-10-30 13:19:30 -04:00
addrdb.cpp	…
addrdb.h	refactor: Remove addrdb.h dependency from node.h	2019-10-29 11:30:12 +02:00
addrman.cpp	…
addrman.h	…
amount.h	…
arith_uint256.cpp	Remove unused includes	2019-10-15 22:56:43 +00:00
arith_uint256.h	Remove unused includes	2019-10-15 22:56:43 +00:00
attributes.h	…
banman.cpp	…
banman.h	Merge #17297: refactor: Remove addrdb.h dependency from node.h	2019-11-04 13:18:27 +01:00
base58.cpp	…
base58.h	…
bech32.cpp	Add some general std::vector utility functions	2019-10-16 08:56:57 -07:00
bech32.h	…
bitcoin-cli-res.rc	…
bitcoin-cli.cpp	Merge #17302: cli: Add "headers" and "verificationprogress" to -getinfo	2019-10-30 12:38:31 +01:00
bitcoin-tx-res.rc	…
bitcoin-tx.cpp	refactor: Remove redundant c_str() calls in formatting	2019-10-28 13:31:33 +01:00
bitcoin-wallet-res.rc	…
bitcoin-wallet.cpp	refactor: Remove redundant c_str() calls in formatting	2019-10-28 13:31:33 +01:00
bitcoind-res.rc	…
bitcoind.cpp	Merge #16839: Replace Connman and BanMan globals with NodeContext local	2019-10-30 12:35:41 +01:00
blockencodings.cpp	[validation] Add CValidationState subclasses	2019-10-29 15:46:45 -04:00
blockencodings.h	Remove unused includes	2019-10-15 22:56:43 +00:00
blockfilter.cpp	…
blockfilter.h	…
bloom.cpp	…
bloom.h	…
chain.cpp	…
chain.h	chain: Set all CBlockIndex members to null, remove SetNull helper	2019-10-16 13:06:50 -04:00
chainparams.cpp	Chainparams: Use name constants in chainparams initialization	2019-10-29 20:27:30 +01:00
chainparams.h	doc: Remove explicit network name references	2019-11-01 12:06:35 +01:00
chainparamsbase.cpp	…
chainparamsbase.h	doc: Remove explicit network name references	2019-11-01 12:06:35 +01:00
chainparamsseeds.h	…
checkqueue.h	…
clientversion.cpp	…
clientversion.h	…
coins.cpp	…
coins.h	…
compat.h	…
compressor.cpp	Remove unused includes	2019-10-15 22:56:43 +00:00
compressor.h	…
core_io.h	…
core_memusage.h	…
core_read.cpp	…
core_write.cpp	…
cuckoocache.h	…
dbwrapper.cpp	…
dbwrapper.h	Remove unused includes	2019-10-15 22:56:43 +00:00
dummywallet.cpp	scripted-diff: Rename InitInterfaces to NodeContext	2019-10-28 10:30:51 -04:00
flatfile.cpp	…
flatfile.h	…
fs.cpp	Fix occurences of c_str() used with size() to data()	2019-10-28 13:41:45 +01:00
fs.h	…
hash.cpp	…
hash.h	…
httprpc.cpp	Fix occurences of c_str() used with size() to data()	2019-10-28 13:41:45 +01:00
httprpc.h	Remove unused includes	2019-10-15 22:56:43 +00:00
httpserver.cpp	http: add missing header bootlegged by boost < 1.72	2019-10-25 13:11:09 +00:00
httpserver.h	Remove unused includes	2019-10-15 22:56:43 +00:00
indirectmap.h	…
init.cpp	Merge #17286: Fix help-debug -checkpoints	2019-11-01 11:41:45 +01:00
init.h	Pass NodeContext, ConnMan, BanMan references more places	2019-10-28 10:30:51 -04:00
key.cpp	…
key.h	refactor: Remove unused CExt{Pub,}Key (de)serialization methods	2019-10-22 00:07:31 +02:00
key_io.cpp	Remove unused includes	2019-10-15 22:56:43 +00:00
key_io.h	…
limitedmap.h	…
logging.cpp	util: Filter control characters out of log messages	2019-10-15 10:53:17 +02:00
logging.h	Replace the LogPrint function with a macro	2019-10-22 13:44:51 -07:00
memusage.h	…
merkleblock.cpp	…
merkleblock.h	…
miner.cpp	[validation] Add CValidationState subclasses	2019-10-29 15:46:45 -04:00
miner.h	…
net.cpp	Merge #17279: refactor: Remove redundant c_str() calls in formatting	2019-10-28 15:10:06 -04:00
net.h	scripted-diff: Remove g_connman, g_banman globals	2019-10-28 10:30:51 -04:00
net_permissions.cpp	…
net_permissions.h	…
net_processing.cpp	Merge #15921: validation: Tidy up ValidationState interface	2019-10-30 15:37:34 +01:00
net_processing.h	[validation] Add CValidationState subclasses	2019-10-29 15:46:45 -04:00
net_types.h	refactor: Remove addrdb.h dependency from node.h	2019-10-29 11:30:12 +02:00
netaddress.cpp	…
netaddress.h	Remove unused includes	2019-10-15 22:56:43 +00:00
netbase.cpp	doc: Fix some misspellings	2019-11-04 04:22:53 -05:00
netbase.h	…
netmessagemaker.h	…
noui.cpp	refactor: Remove redundant c_str() calls in formatting	2019-10-28 13:31:33 +01:00
noui.h	…
optional.h	…
outputtype.cpp	Add some general std::vector utility functions	2019-10-16 08:56:57 -07:00
outputtype.h	…
pow.cpp	…
pow.h	…
prevector.h	Remove unused includes	2019-10-15 22:56:43 +00:00
protocol.cpp	…
protocol.h	Remove unused includes	2019-10-15 22:56:43 +00:00
psbt.cpp	Remove unused includes	2019-10-15 22:56:43 +00:00
psbt.h	refactor: Remove redundant PSBT copy constructor	2019-11-01 18:12:57 -04:00
pubkey.cpp	…
pubkey.h	refactor: Remove unused CExt{Pub,}Key (de)serialization methods	2019-10-22 00:07:31 +02:00
random.cpp	random: remove call to RAND_screen() (Windows only)	2019-10-18 14:24:21 -04:00
random.h	Add assertion to randrange that input is not 0	2019-10-28 16:42:39 -07:00
rest.cpp	Remove unused includes	2019-10-15 22:56:43 +00:00
reverse_iterator.h	…
reverselock.h	…
scheduler.cpp	…
scheduler.h	…
serialize.h	Remove unused includes	2019-10-15 22:56:43 +00:00
shutdown.cpp	…
shutdown.h	…
span.h	…
streams.h	Remove unused includes	2019-10-15 22:56:43 +00:00
sync.cpp	refactor: Remove redundant c_str() calls in formatting	2019-10-28 13:31:33 +01:00
sync.h	…
threadinterrupt.cpp	…
threadinterrupt.h	Remove unused includes	2019-10-15 22:56:43 +00:00
threadsafety.h	…
timedata.cpp	…
timedata.h	…
tinyformat.h	…
torcontrol.cpp	…
torcontrol.h	Remove unused includes	2019-10-15 22:56:43 +00:00
txdb.cpp	Add some general std::vector utility functions	2019-10-16 08:56:57 -07:00
txdb.h	Remove unused includes	2019-10-15 22:56:43 +00:00
txmempool.cpp	Merge #17316: refactor: Replace all uses of boost::optional with our own Optional type	2019-10-30 14:20:17 -04:00
txmempool.h	refactor: Replace all uses of boost::optional with our own Optional type	2019-10-30 14:27:31 +01:00
ui_interface.cpp	…
ui_interface.h	Remove unused includes	2019-10-15 22:56:43 +00:00
uint256.cpp	Remove unused includes	2019-10-15 22:56:43 +00:00
uint256.h	Remove unused includes	2019-10-15 22:56:43 +00:00
undo.h	…
validation.cpp	doc: Fix some misspellings	2019-11-04 04:22:53 -05:00
validation.h	[validation] Remove fMissingInputs from AcceptToMemoryPool()	2019-10-29 15:46:45 -04:00
validationinterface.cpp	[validation] Add CValidationState subclasses	2019-10-29 15:46:45 -04:00
validationinterface.h	[validation] Add CValidationState subclasses	2019-10-29 15:46:45 -04:00
version.h	…
versionbits.cpp	…
versionbits.h	…
versionbitsinfo.cpp	…
versionbitsinfo.h	…
walletinitinterface.h	scripted-diff: Rename InitInterfaces to NodeContext	2019-10-28 10:30:51 -04:00
warnings.cpp	…
warnings.h	Remove unused includes	2019-10-15 22:56:43 +00:00